search

datenanfragen / website

The Datenanfragen.de website including the request PDF generator and company information database
https://www.datenanfragen.de
MIT License
93 stars 125 forks source link

/categories/ returns no results #444

Open KoesterD opened 4 years ago

KoesterD commented 4 years ago

When I visit https://www.datenanfragen.de/categories/ it shows 2 pages of results, but both are empty.

I expect that page to return the company categories.

This was tested in Chromium 85, Chrome 85, Microsoft Edge 86, Firefox 46 and Firefox 81 with both adblockers active and inactive.

KoesterD commented 4 years ago

image image

This is what I see when I visit that page.

baltpeter commented 4 years ago

Good catch, thanks! I'll open this for Hacktoberfest if anyone wants to pick it up.

Raj-Datta-Manohar commented 4 years ago

Hi, I would like to work on this!

baltpeter commented 4 years ago

@Raj-Datta-Manohar Sure, thanks. I'll assign you.

kyteinsky commented 3 years ago

I can see this issue persists. I want to resolve this one. Would you please provide some pointers where I should look first in the codebase?

Thanks.

baltpeter commented 3 years ago

@kyteinsky These pages are generated automatically by Hugo. Without having looked into this, this probably happens as we don't have anything for them in our codebase: https://gohugo.io/templates/

kyteinsky commented 3 years ago

Hmm, I see. Is this where the categories list is present, as I see deploy.sh clones the data repo. And do I need to bind some link or click action to the individual categories, or is that work already done? I will look into Hugo files in this repo to find out more.

baltpeter commented 3 years ago

The schema defines a list of all the valid categories, yes. But that's not something you'd have to handle. The Hugo taxonomy stuff should take care of that based on the companies (and thus categories) that are actually present.

And do I need to bind some link or click action to the individual categories, or is that work already done?

Not sure I understand that question, to be honest. The problem here is likely that our default summary templates don't know how to render a category. You'd have to create one for that. The category list pages (e.g.: https://www.datarequests.org/categories/school) do already work, as they have a summary template already: https://github.com/datenanfragen/website/blob/master/layouts/partials/summary-company.html