Fix unexpected behaviour of custom fields in ID data controls

datenanfragen / website

The Datenanfragen.de website including the request PDF generator and company information database

https://www.datenanfragen.de

MIT License

89 stars 125 forks source link

Fix unexpected behaviour of custom fields in ID data controls #553

Open baltpeter opened 3 years ago

baltpeter commented 3 years ago

Not super happy with this implementation, unfortunately. I'm afraid, it causes some quite unexpected behaviour of fields vanishing, moving around and merging. And I am pretty sure that the last thing in the video is also a bug, though I am not sure what causes it:

Peek 2020-11-14 19-51

_Originally posted by @baltpeter in https://github.com/datenanfragen/website/pull/485#discussion_r523450733_

ThisIsFaar commented 2 years ago

can you describe more about the issue? from my side custom fields are working fine, how can I generate this issue in any steps?

baltpeter commented 2 years ago

@ThisIsFaar There's still quite a few issues. This needs more testing but here's a couple I've just discovered:

https://user-images.githubusercontent.com/4048809/137397170-9b5bd485-2f09-48cc-ab60-625d212d1120.mp4

https://user-images.githubusercontent.com/4048809/137397229-a6919623-0031-4cbf-86d8-74a8ce60c767.mp4

https://user-images.githubusercontent.com/4048809/137397384-6e63c374-8cc7-4677-a35f-acb44ff1675f.mp4