search

datenanfragen / website

The Datenanfragen.de website including the request PDF generator and company information database
https://www.datenanfragen.de
MIT License
95 stars 125 forks source link

Switch suggest page to react-jsonschema-form? #561

Open baltpeter opened 3 years ago

baltpeter commented 3 years ago

Unfortunately, brutusin/json-forms has been unmaintained for a while and we're seeing a number of issues in our usage. I have recently discovered react-jsonschema-form which may be a good alternative.

mal-tee commented 3 years ago

Might be interesting for datenanfragen/company-json-generator#17 as well

baltpeter commented 3 years ago

Another option that I have not yet evaluated: https://github.com/json-editor/json-editor

baltpeter commented 1 year ago

Yet another contender: https://github.com/iway1/react-ts-form (shouldn't be too hard to automatically generate a zod schema from our JSON schema).

baltpeter commented 1 year ago

I've just had a look at the docs and demo of react-jsonschema-form. Looks pretty cool, seems well maintained, and from what I've seen, it supports everything we're looking for.

I haven't really looked closer into json-editor/json-editor because that is not React-based and I would definitely prefer something with native React support. Our previous approach with brutusin/json-forms really wasn't clean.

I haven't really looked into react-ts-form either. At first glance, it seems less comprehensive than react-jsonschema-form.

christian-weiss commented 10 months ago

brutusin/json-forms is unmaintained, but there are 2 active maintained forks: https://github.com/saicheck2233/json-forms (106 commits ahead of origin) https://github.com/WSUCEG-7140/Team-Alpha (141 commits ahead of origin)

I did not look into these 3 packages, so i do not want to judge about "cleanness of this approach", but i dislike that version string is at 0.0.0 and no releases published at npmjs.com.

Maybe an option, if we do not want to change much...

baltpeter commented 9 months ago

For the record, some more relevant discussion on why brutusin/json-forms is not an option: https://github.com/datenanfragen/company-json-generator/issues/17

But I have also already started (and mostly completed) work on a custom React JSON schema form component that works really well for our purposes. Unfortunately, there are too many things on my plate right now, so I haven't found the time to publish it yet.