search

datenanfragen / website

The Datenanfragen.de website including the request PDF generator and company information database
https://www.datenanfragen.de
MIT License
95 stars 125 forks source link

Native (p)react component for search autocomplete #649

Open zner0L opened 3 years ago

zner0L commented 3 years ago

Currently, we are using autocomplete.js by algolia, which is not properly integrated into preact and rather manipulates the DOM after preact. This leads to all kinds of problems in the component lifecycle, like in #645. Also, autocomplete.js is very heavy and slows down our pageload.

A solution to this would include writing our own search component, maybe using accessible-autocomplete and fetching the search results manually. Also take a look at the typesense API for how to get the results from our search server.

rutulganatra commented 3 years ago

@zner0L @baltpeter Hi there! I'm interested in fixing this issue

zner0L commented 3 years ago

I am sorry, but this needs pretty in depth knowledge of our codebase as well as potentially changes to our API, so I don't think we can accept outside contributions for this issue.