is_defined not exists, wrong system_defaults template path, report_sales_by_periods sql query fix

[GoogleCodeExporter]

You will find attached a small patch thats fixes some issues in the current 
simple invoices development version. Fix is for the revision 3693.

- change 'is_defined' to 'defined'
- fix sql query for report_sales_by_periods (table prefix)
- system defaults path to the invoice templates

Original issue reported on code.google.com by drscr...@gmail.com on 25 Sep 2011 at 7:45

Attachments:

• sys_r3693.diff

[GoogleCodeExporter]

Thank you for your commit. I will apply the patch later today.

Just one thing I have already seen in your code. In the file 
sys/modules/cron/add.php you have added a ?> at the end of the file. You should 
not do this. Because it could happen that there is a new line after it and then 
we already send something to the browser and the header() values can not be 
sent anymore.

Original comment by r.luthi...@gmail.com on 26 Sep 2011 at 12:16

• Changed state: Open-Accepted

[GoogleCodeExporter]

Ohh good to know - I'm not really sure why i've added the ?> to the file ;-)

Original comment by drscr...@gmail.com on 26 Sep 2011 at 1:30

[GoogleCodeExporter]

I applied all of them. Code is in revision 3697.

Original comment by r.luthi...@gmail.com on 11 Oct 2011 at 11:24

• Changed state: Closed-Fixed

[GoogleCodeExporter]

thanks guys for commiting this!!

Original comment by jus...@kelly.org.au on 12 Oct 2011 at 2:28