datguypiko / Firefox-Mod-Blur

Firefox Theme - For dark theme lovers / More compact / Modular / Blur
1.24k stars 59 forks source link

Bugged Icons #130

Closed RustyElbow closed 2 months ago

RustyElbow commented 2 months ago

Icons in application menu are blacked out and have no spacing.

Screenshot 2024-07-08 121128

Thanks.

datguypiko commented 2 months ago

What version of firefox and what OS ?

This is how mine looks 127.0.2 win11. image

RustyElbow commented 2 months ago

127.0.2 Win 11 23H2

datguypiko commented 2 months ago

Do you have other modifications done? Remove everything except the userChrome.css and icons_in_main_menu file.

Maybe try creating new firefox profile. Go to about:profiles and create new profile image

Maybe you have about:config some preferences set that works against it.

RustyElbow commented 2 months ago

Ah yes, I have a modified user.js. Now I have to find the line thats causing the issue...

SmooQ commented 2 months ago

Ah yes, I have a modified user.js. Now I have to find the line thats causing the issue...

Have you found the error in your user.js? I have the same problem : /

RustyElbow commented 2 months ago

I've had no luck... It still does it even though the user.js is gone. I would've thought SVG would be causing the issue but even with that enabled still the same issue.

datguypiko commented 2 months ago

I figured what's the issue. You downloaded the v2.7.8_ModBlur-Firefox_v126.zip file that doesnt have the icons in main menu fixes https://github.com/datguypiko/Firefox-Mod-Blur/commit/795497f0cbaa502fc815bb77d5c03cd63babbd52 that was added after.

In this page https://github.com/datguypiko/Firefox-Mod-Blur/releases/tag/v2.7.8 at the top download from "Latest Full Repository"

Or update the mod file code with the new one.

I will push all the updates to new release after firefox v128 drop in few days.

RustyElbow commented 2 months ago

Brilliant! thank you. Will this update be the one with oneliner?

RustyElbow commented 2 months ago

128 has been release btw!

datguypiko commented 2 months ago

Brilliant! thank you. Will this update be the one with oneliner?

no, not yet but if you want you can use this for now.

add it at the end of userChrome

/* Menu button */
#PanelUI-button {
  order: -2 !important;
}

#PanelUI-menu-button {
  padding: 0 !important;
  padding-left: 2px !important;
}

#alltabs-button {
  display: none !important;
}

:root {
  --uc-toolbar-position: 4;
}

:root {
      --firefoxcss-urlbar-min-width: 45vw;
      --firefoxcss-urlbar-max-width: 45vw;
}

#nav-bar {
    order: 1;
}

#titlebar {
    order: 2;
}

#PersonalToolbar {
    order: 3;
}

#TabsToolbar > .titlebar-spacer {
  display: none !important;
}

@media screen and (max-width: 1500px) {
  #urlbar-container{ 
/*     min-width: unset !important; 
    width: auto !important; 
    flex-shrink: 1 !important; */
  }
}  

@media (min-width: 1100px) {

  #navigator-toolbox { display: flex; flex-wrap: wrap; flex-direction: row; }

  #nav-bar {
    order: 1;
    width: var(--firefoxcss-urlbar-min-width);
/* var(--firefoxcss-control-buttons-margin); */
  }

  #nav-bar #urlbar-container { min-width: unset !important; width: auto !important; }

  #titlebar {
    order: 2;
    width: calc(100vw - var(--firefoxcss-urlbar-min-width) - 1px);
  }

/* --firefoxcss-control-buttons-margin */
  #PersonalToolbar {
    order: 3;
    width: 100%;

  }

  #navigator-toolbox:focus-within #nav-bar { width: var(--firefoxcss-urlbar-max-width); }
  #navigator-toolbox:focus-within #titlebar { width: calc(100vw - var(--firefoxcss-urlbar-max-width) - 1px); }
}
RustyElbow commented 2 months ago

Thank you! :)

Kajal4414 commented 1 month ago

Brilliant! thank you. Will this update be the one with oneliner?

no, not yet but if you want you can use this for now.

add it at the end of userChrome

/* Menu button */
#PanelUI-button {
  order: -2 !important;
}

#PanelUI-menu-button {
  padding: 0 !important;
  padding-left: 2px !important;
}

#alltabs-button {
  display: none !important;
}

:root {
  --uc-toolbar-position: 4;
}

:root {
      --firefoxcss-urlbar-min-width: 45vw;
      --firefoxcss-urlbar-max-width: 45vw;
}

#nav-bar {
    order: 1;
}

#titlebar {
    order: 2;
}

#PersonalToolbar {
    order: 3;
}

#TabsToolbar > .titlebar-spacer {
  display: none !important;
}

@media screen and (max-width: 1500px) {
  #urlbar-container{ 
/*     min-width: unset !important; 
    width: auto !important; 
    flex-shrink: 1 !important; */
  }
}  

@media (min-width: 1100px) {

  #navigator-toolbox { display: flex; flex-wrap: wrap; flex-direction: row; }

  #nav-bar {
    order: 1;
    width: var(--firefoxcss-urlbar-min-width);
/* var(--firefoxcss-control-buttons-margin); */
  }

  #nav-bar #urlbar-container { min-width: unset !important; width: auto !important; }

  #titlebar {
    order: 2;
    width: calc(100vw - var(--firefoxcss-urlbar-min-width) - 1px);
  }

/* --firefoxcss-control-buttons-margin */
  #PersonalToolbar {
    order: 3;
    width: 100%;

  }

  #navigator-toolbox:focus-within #nav-bar { width: var(--firefoxcss-urlbar-max-width); }
  #navigator-toolbox:focus-within #titlebar { width: calc(100vw - var(--firefoxcss-urlbar-max-width) - 1px); }
}

Win10 Capture Capture1

datguypiko commented 1 month ago

Brilliant! thank you. Will this update be the one with oneliner?

no, not yet but if you want you can use this for now.

add it at the end of userChrome

/* Menu button */
#PanelUI-button {
  order: -2 !important;
}

#PanelUI-menu-button {
  padding: 0 !important;
  padding-left: 2px !important;
}

#alltabs-button {
  display: none !important;
}

:root {
  --uc-toolbar-position: 4;
}

:root {
      --firefoxcss-urlbar-min-width: 45vw;
      --firefoxcss-urlbar-max-width: 45vw;
}

#nav-bar {
    order: 1;
}

#titlebar {
    order: 2;
}

#PersonalToolbar {
    order: 3;
}

#TabsToolbar > .titlebar-spacer {
  display: none !important;
}

@media screen and (max-width: 1500px) {
  #urlbar-container{ 
/*     min-width: unset !important; 
    width: auto !important; 
    flex-shrink: 1 !important; */
  }
}  

@media (min-width: 1100px) {

  #navigator-toolbox { display: flex; flex-wrap: wrap; flex-direction: row; }

  #nav-bar {
    order: 1;
    width: var(--firefoxcss-urlbar-min-width);
/* var(--firefoxcss-control-buttons-margin); */
  }

  #nav-bar #urlbar-container { min-width: unset !important; width: auto !important; }

  #titlebar {
    order: 2;
    width: calc(100vw - var(--firefoxcss-urlbar-min-width) - 1px);
  }

/* --firefoxcss-control-buttons-margin */
  #PersonalToolbar {
    order: 3;
    width: 100%;

  }

  #navigator-toolbox:focus-within #nav-bar { width: var(--firefoxcss-urlbar-max-width); }
  #navigator-toolbox:focus-within #titlebar { width: calc(100vw - var(--firefoxcss-urlbar-max-width) - 1px); }
}

Win10 Capture Capture1

Look at file structure in installation instructions you are probably missing some files.

Kajal4414 commented 1 month ago

Brilliant! thank you. Will this update be the one with oneliner?

no, not yet but if you want you can use this for now. add it at the end of userChrome

/* Menu button */
#PanelUI-button {
  order: -2 !important;
}

#PanelUI-menu-button {
  padding: 0 !important;
  padding-left: 2px !important;
}

#alltabs-button {
  display: none !important;
}

:root {
  --uc-toolbar-position: 4;
}

:root {
      --firefoxcss-urlbar-min-width: 45vw;
      --firefoxcss-urlbar-max-width: 45vw;
}

#nav-bar {
    order: 1;
}

#titlebar {
    order: 2;
}

#PersonalToolbar {
    order: 3;
}

#TabsToolbar > .titlebar-spacer {
  display: none !important;
}

@media screen and (max-width: 1500px) {
  #urlbar-container{ 
/*     min-width: unset !important; 
    width: auto !important; 
    flex-shrink: 1 !important; */
  }
}  

@media (min-width: 1100px) {

  #navigator-toolbox { display: flex; flex-wrap: wrap; flex-direction: row; }

  #nav-bar {
    order: 1;
    width: var(--firefoxcss-urlbar-min-width);
/* var(--firefoxcss-control-buttons-margin); */
  }

  #nav-bar #urlbar-container { min-width: unset !important; width: auto !important; }

  #titlebar {
    order: 2;
    width: calc(100vw - var(--firefoxcss-urlbar-min-width) - 1px);
  }

/* --firefoxcss-control-buttons-margin */
  #PersonalToolbar {
    order: 3;
    width: 100%;

  }

  #navigator-toolbox:focus-within #nav-bar { width: var(--firefoxcss-urlbar-max-width); }
  #navigator-toolbox:focus-within #titlebar { width: calc(100vw - var(--firefoxcss-urlbar-max-width) - 1px); }
}

Win10 Capture Capture1

Look at file structure in installation instructions you are probably missing some files.

I see, you're absolutely correct. The 'ASSETS' folder was missing from the installation directory. I apologize for overlooking this. The issue has been resolved, thank you.