search

datmeal / tooki.gg-lostarkchecklist

tooki.gg is a Lost Ark web application that includes a checklist, event timers, and calculators.
https://tooki.gg
9 stars 3 forks source link

Starting to replace moment.js with date-fns/date-fns-tz libraries #14

Closed geewhombee closed 2 years ago

geewhombee commented 2 years ago

I removed the use of moment.js from App.js and used date-fns/date-fns-tz instead. I don't know a lot of js and react, but I believe I have recreated the functionality using date-fns libraries. Please confirm that I am setting the currentDay and currentTime event state variables appropriately.

Also started to implement date-fns use in Events.js, so far only top center time and day fields have been updated to use date-fns. I wanted to get conformation that I am doing things appropriately before working through Events.js since moment.js is used more widely there. Let me know if I'm on the right track!

datmeal commented 2 years ago

Thanks! I will check this out and let you know

datmeal commented 2 years ago

Looks good to me. Thanks! Would be cool if we can eventually remove moment completely