datmeal
commented
2 years ago @Clodolt Hey, thanks for helping out with the code! There are several weird gotchas that I've had to deal with when making this Event Page, and one of them seems to be popping back up with this PR:
When the time is about to roll over to a new day (right before 00:00) it is supposed to show events that will happen all the way up to about 05:00 the next day, so events that happen at 00:00, 01:00, should be visible before the actual day begins. With this PR, it seems that at 23:59, it no longer shows events that will happen the next day until the clock reaches 00:00.
This is how it should look:
I was previously able to test this using the code under //Test Time in the refreshClock() function, if that helps!
Clodolt
Also, can we get back the humanized time text under the events? So instead of "3 hour 23 minutes and 51 seconds" it says "4 hours" etc
Note: Two instances are left as the instances of moment.js are left as they seem redundant but break the code if changed at all
Instance 1:
let eventTime = moment(time, "HH:mm") // .subtract(offsetSeconds, "seconds") .format("HH:mm");Instance 2:
const eventTime = moment(timeText, "HH:mm").format("HH:mm");