search

datmeal / tooki.gg-lostarkchecklist

tooki.gg is a Lost Ark web application that includes a checklist, event timers, and calculators.
https://tooki.gg
9 stars 3 forks source link

Replace moment.js with date-fns #8

Open datmeal opened 2 years ago

datmeal commented 2 years ago

moment.js is deprecated and uses mutable, switch to the more modern date-fns for better support and probably less bugs

geewhombee commented 2 years ago

Hey there, I have been working on a potential solution for this issue. This is my first time working on an open source project and i'm not sure what the protocol is. I have my work in a new branch called moment-replacement. would it be alright to push this branch to this repo for you to take a look at?

Edit: I also have a forked version with my changes implemented on main if thats easier to work with.

datmeal commented 2 years ago

Sorry for the late reply! I am also new to Github for managing the code so I'm still figuring this out as well. I think it would be best if you could push the branch to the repo so I can see how it works on the browser!

datmeal commented 2 years ago

Nevermind the last comment, I figured out how to checkout this branch.

datmeal commented 2 years ago

I'll keep this issue open in case we can replace even more/all of moment with better solutions later

Clodolt commented 2 years ago

16 #14

I have taken a little time to look at the rest of the moment usage, see pull request for details

datmeal commented 2 years ago

Sunday events may not be appearing, I'm thinking this has something to do with the day rotating from day 6 back to day 0 or something to that effect