datn02 / pe

0 stars 0 forks source link

Note name considers "?" as a special character #2

Open datn02 opened 2 years ago

datn02 commented 2 years ago

Workplace: CS2113T->notes Command entered: add "fooo?" "."

"?" character, in this case, is considered a special character, while "." (period) is not, although they are the same kind of character. Cannot find a reason anywhere to justify why "?" cannot be included in note name

image.png

nus-se-bot commented 2 years ago

Team's Response

Thank you for report.

Please refer to the UG again for more clarification.

The first field refer to the note name and the second field refer to the note content. We only filter the note name as mentioned in the UG.

The key points are firstly question mark could be a special character in some file system and may cause an issue when writing a question mark to the file system. Secondly the concern Terminus have is the file name issue hence content filter is not part of our scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: If both note name and note content are to be written to the memory, then why do note names must not have special characters? When both contents are to be written to the same memory anyway? Why not use the same handling technique of note contents for note names?


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Could be Low, since it might cause some minor inconveniences for average usage.