datn02 / pe

0 stars 0 forks source link

Schedule: Duration of 0 hours can be added into the schedule #4

Open datn02 opened 2 years ago

datn02 commented 2 years ago

Command inputted: add "?&^&" "Friday " "24:00" "0" "https://asd.com"

Duration of 0 hours is nonsense for any scheduled meeting or lectures, but is accepted in this case.

image.png

nus-pe-script commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

0 duration should be rejected for schdule

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


image.png


[original: nus-cs2113-AY2122S1/pe-interim#12] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the feedback.

To cater for meeting that last a less than an hour such as 15 min or 30min, we allow duration of 0.

Hence the team has decided to reject this issue as it is a design choice.

In addition, for this specific issue, it will be rejected as it was tested during the Part 2.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The duration of 0 doesn't make sense, logic-wise, and reality-wise. At least you can add a note and/or throw an error exception when the user inputs duration of 0 hours, then specify it.


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: This 0 hours duration could potentially cause further bugs if not handled (specifically, when user both set start time to "24:00" and duration to "0"). Should be Medium Severity