datn02 / pe

0 stars 0 forks source link

Schedule: duration of 0 hours can mess up time start and time end of a schedule #5

Open datn02 opened 2 years ago

datn02 commented 2 years ago

Command inputted: add "?&^&" "Friday " "24:00" "0" "https://asd.com"

Since 0 hours have been entered, and the start time is "24:00", or can be interpreted as "0:00am", this should end at "24:00". However, it rolled back a minute earlier, at "23:59", which makes no sense.

image.png

soc-se-bot commented 2 years ago

Team's Response

Thank you for your report.

First of all, we disagree that this is severity.High as this flaw does not affect most users and causes major problems for users. Most users who would like to add a schedule starting at midnight would start on the next day and set the start time as 00:00.

As users can start at 00:00 in the following day, and 24:00 is an unlikely start time for users, we deem that this flaw appears only in very rare situations and does not affect the normal operations of the product.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: At least Medium severity, since this input is considered is unlikely and flawed, dev team should've added an exception to this input. In addition, this input would make the math calculation of start time and end time useless and wrong.