Lowercase node_name in comparison to match even if it is uppercase

datnguye / dbterd

Generate the ERD as a code from dbt artifacts

MIT License

198 stars 28 forks source link

resolves https://github.com/datnguye/dbterd/issues/73

Description

Fixed a bug that prevented ER diagrams from being output when data source table names were capitalized. This is because the rule part is lower(), but lower is not applied in the is_satisfied_by_exact function. Therefore, the result of the is_selected_table function was determined to be false, and the ER diagram was not output as expected.

https://github.com/datnguye/dbterd/blob/main/dbterd/adapters/filter.py#L77

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2ae1867) 85.60% compared to head (b4447a2) 85.60%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #74 +/- ## ======================================= Coverage 85.60% 85.60% ======================================= Files 31 31 Lines 910 910 ======================================= Hits 779 779 Misses 131 131 ```

datnguye / dbterd