Replace special symbol characters with other characters to allow them to be drawn as mermaid

syou6162 commented 7 months ago

resolves https://github.com/datnguye/dbterd/issues/81

Description

Mermaid may not be able to render special characters. To deal with such cases, we have made changes to replace or omit special characters.

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a6cf5f4) 85.68% compared to head (d5a402f) 100.00%. Report is 8 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #85 +/- ## ============================================ + Coverage 85.68% 100.00% +14.31% ============================================ Files 31 31 Lines 915 930 +15 ============================================ + Hits 784 930 +146 + Misses 131 0 -131 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

datnguye commented 7 months ago

LGTM for the code changes, thanks for your proactive contribution so far @syou6162 ❤️

I will create v1.11.0b1 right after this gets merged

datnguye / dbterd