[coderschool.vn iOS Bootcamp] - Review My Pre-work

[datnguyen92]

I have completed my pre-work. Please review it “/cc @chug2k”

[chug2k]

:+1: Excellent job with the Tip Calculator! Congratulations, you're accepted to the class - see you on November 9th! We will email you at your gmail.com email address soon with information about exactly where to meet.

• Great job with the themes! I like what you did with the array of colors for the themes; that's a clever solution. The themes also look great.
• Great job with the NSUserDefaults and checking to see how much time has elapsed. onBackgroundState is one way to handle saving the correct values. You're limited in the amount of processing you can do from a background state, but yours should be fine.
• You have an interesting way of naming variables. Hungarian notation isn't common in Swift, but your code otherwise is pretty clean and consistent. You can check https://github.com/raywenderlich/swift-style-guide for a definitive style guide.
• Good job dealing with the keyboard frame!
• Small, small thing: if you have an empty completion block, you can just pass nil. (line 202) But good job with the animations!
• Another small, small thing: I'm able to type in an invalid number like "250.125.152".

Great job! One of the best submissions.

/cc @marcusellison @harley @minhchau273

[datnguyen92]

Thank you for reviewing my work and for all the feedback. I am more than happy for being accepted to this November Bootcamp and really excited to be a part of this. I would love to see you there.