Homework Week 3 Submission

[datnguyen92]

Here is my assignment 3 but still need some improvement. I will keep working on it to make it better. Thank you

/cc @coderschoolreview

[coderschoolreview]

:+1: Nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API.

Grading Summary

• Functionality: Good
• Code Style: Average
• Visual Design: Good
• Usability: Good
• Overall: Good

Detailed Notes

Great things:

• Nice work specifying the Auto Layout constraints.
• Nice work handling the retweet label by using TweetCell and RetweetCell. The other way is using dynamic constraints. This is a situation where its not possible to specify the behavior that you want solely using Interface Builder.
• Nice work handling the post tweet insertion into the feed. In real MVC apps, the more polished experiences have to do a certain amount of local object management to make a fully seamless experience. But it only works for new tweet. When I reply, then back to home page, I have to pull to refresh to see that reply.

Some small comments:

• Note that you should resolve all the Auto Layout constraint warnings in your nibs.
• You shoud try setting up the controls within the Tweet cells. It can sometimes be hard to have a clean design for embedded controls because it usually involves cumbersome plumbing. This is an instance where I think having the model handle the network action helps greatly simplify the implementation.
• Your app crashes when I tap reply in TweetCell.
• A reply begins with username, so the countdown should have be initialized at 140 - username.length
• Good job for disabling Tweet button when then text's length > 140, but after that, though I erase some character to make length <= 140, I cannot tap Tweet
• In NewTweetViewController, you should use UITextView instead of UITextField. With UITextField, the long text is only shown on a single line, so you cannot view the whole text.
• I cannot tap to RetweetCell to view details, but the TweetCell is ok.

Good submission overall. This assignment is pretty hard, congrats on completing it! :star2: It was here to teach you about keeping track of "state" of objects, and also to be the first assignment to accept user input.

[coderschoolreview]

Some notes in your code:

• Please use if let to unwrap variables. It's unsafe when using !. This's very important.
• Don't abuse blank lines.
• Please remove unnecessary self.
• Use default value for variables to avoid unwrapping them when using.
• You should use extension to make your code more clear. Example:

extension MainViewController: UITableViewDelegate, UITableViewDataSource {
    // Implement methods of table view
    func tableView(tableView: UITableView, cellForRowAtIndexPath indexPath: NSIndexPath) -> UITableViewCell {
        // Your code
    }

    func tableView(tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
        // Your code
    }
}

• In override functions, if you don't implement any special thing, you can remove them. Example you can remove these function in TweetCell:

   override func awakeFromNib() {
        super.awakeFromNib()
        // Initialization code
    }

    override func setSelected(selected: Bool, animated: Bool) {
        super.setSelected(selected, animated: animated)

        // Configure the view for the selected state
    }

Please view my comments in your commits for more details.