Move create types to right lifecycle - Githubissues

datocms / gatsby-source-datocms

Official GatsbyJS source plugin to pull content from DatoCMS

MIT License

140 stars 51 forks source link

Move create types to right lifecycle #101

Closed sidharthachatterjee closed 4 years ago

sidharthachatterjee commented 4 years ago

There's a race condition bug in gatsby core at the moment where queries are run between createSchemaCustomization and sourceNodes and because of which consecutive runs after the first one fail when running develop with ENABLE_GATSBY_REFRESH_ENDPOINT set to true

This PR moves createTypes to the right lifecycle (createSchemaCustomization) which fixes this issue
Also removed some extra work that is no longer necessary (copying over fragments) after https://github.com/gatsbyjs/gatsby/pull/15284

stefanoverna commented 4 years ago

Thanks @sidharthachatterjee, we'll test it a little bit and release it if everything works fine :)