search

datocms / gatsby-source-datocms

Official GatsbyJS source plugin to pull content from DatoCMS
MIT License
140 stars 50 forks source link

support react-helmet v6 #111

Closed hu0p closed 4 years ago

hu0p commented 4 years ago

React-Helmet stopped supporting default exports in v6.0.0. It looks like they planned this starting from v5.0.0, at which point they began exporting both default and named exports to provide a transition for dependents.

I propose updating the required peer dependency version for react-helmet from a wildcard to any version greater than or equal to v5.0.0 and moving to named exports, which I'm guessing will cover the majority of users. If it doesn't, this will have to be revisited at a later date with some sort of module resolution logic. Alternatively, we could do that now, but this route avoids adding bloat to the codebase.

This resolves #109.

stefanoverna commented 4 years ago

Looks good to me! Thanks @hu0p for the patch, releasing it now as 2.2.1!