datocms / gatsby-source-datocms

Official GatsbyJS source plugin to pull content from DatoCMS
MIT License
140 stars 51 forks source link

Allow gatsby-plugin-image v2 as peer dependency #179

Closed michaellopez closed 2 years ago

michaellopez commented 2 years ago

We have been using gatsby-plugin-image@2.1.0 with gatsby-source-datocms@3.0.10 and it has worked really well for us so far.

Looking at the CHANGELOG for gatsby-plugin-image@2.2.0 the only thing I can see that prompts a major version bump is https://github.com/gatsbyjs/gatsby/pull/32544 (basically when using multiple sources you need to include gatsby-plugin-image in your gatsby-config.js) but the commit itself isn't marked as a breaking change. So I don't really know. Maybe the major version bump was for Gatsby to be able to say that Gatsby v4 requires v2+ of gatsby-plugin-image? 🤷‍♂️

Either way, I manually checled the diff between 1.14.2 and 2.2.0 and I can't see any reason for the major version bump other than the above. The diff is basically only version bumps to dependencies, devDependencies and peerDependencies.

This PR would allow more flexibility for consumers of gatsby-source-datocms.

matjack1 commented 2 years ago

Thanks!