search

datocms / gatsby-source-datocms

Official GatsbyJS source plugin to pull content from DatoCMS
MIT License
140 stars 51 forks source link

Dependencies and peer-dependencies are incorrect #213

Open donaldboulton opened 1 year ago

donaldboulton commented 1 year ago

The below Gatsby plugins should be in dependencies. as well as React and React Dom

"gatsby": "^4.24.0 || ^5.0.0", "gatsby-plugin-image": "^2.0.0 || ^3.0.0", "gatsby-plugin-sharp": "^4.0.0 || ^5.0.0", "gatsby-transformer-remark": "^5.0.0 || ^6.0.0",

preDependencies are totally wrong and point to older Gatsby plugin's.

"peerDependencies": { "gatsby": ">= 4.24.0", "gatsby-plugin-image": ">= 1.0.0", "react": "*", "react-helmet": ">= 5.0.0" },

should be

"peerDependencies": { "gatsby": ">= 5.0.0", "gatsby-plugin-image": ">= 3.0.0", "react": "*", "react-helmet": ">= 6.0.0" },

This is a temp fix. That will work with Gatsby 5

You get rid of react-helmet and datoHelmet and use the new API using Gatsby Head

stefanoverna commented 1 year ago

Our package supports both Gatsby 4 and 5, so that's why we keep "gatsby": ">= 4.24.0" (similar reasoning for gatsby plugins).

I don't understand if having "gatsby": ">= 4.24.0" is a problem for you. Should be compatible with Gatsby 5, right?

graeme120 commented 1 year ago

Our package supports both Gatsby 4 and 5, so that's why we keep "gatsby": ">= 4.24.0" (similar reasoning for gatsby plugins).

I don't understand if having "gatsby": ">= 4.24.0" is a problem for you. Should be compatible with Gatsby 5, right?

I'm having a similar problem. DatoCms is not appearing in Gatsby project's graphiql page. Has this been resolved or has a permanent solution been found?

sistrall commented 1 year ago

Hi @graeme120,

I'll be happy to help, but I need more context: what's the problem? Which version of Gatsby are you using?