search

datocms / js-datocms-client

NodeJS/Browser client for DatoCMS
https://www.datocms.com
MIT License
72 stars 37 forks source link

Typeerror bug in 0.5.0 #15

Closed ismay closed 6 years ago

ismay commented 6 years ago

I just received a PR from greenkeeper for the 0.5.0 update, and the build is failing with the following error:

6:34:01 PM: ✖ Fetching content from DatoCMS
6:34:01 PM:   TypeError: _this.image is not a function
6:34:01 PM:   
6:34:01 PM:   - build.js:83 
6:34:01 PM:     [repo]/[datocms-client]/lib/local/fields/build.js:83:20
6:34:01 PM:   
6:34:01 PM:   - Array.map
6:34:01 PM:   
6:34:01 PM:   - build.js:82 Object.gallery
6:34:01 PM:     [repo]/[datocms-client]/lib/local/fields/build.js:82:32
6:34:01 PM:   
6:34:01 PM:   - build.js:121 build
6:34:01 PM:     [repo]/[datocms-client]/lib/local/fields/build.js:121:38
6:34:01 PM:   
6:34:01 PM:   - Item.js:153 Item.readAttribute
6:34:01 PM:     [repo]/[datocms-client]/lib/local/Item.js:153:34
6:34:01 PM:   
6:34:01 PM:   - Item.js:50 Item.get [as images]
6:34:02 PM:     [repo]/[datocms-client]/lib/local/Item.js:50:23
6:34:02 PM:   
6:34:02 PM:   - dato.config.js:113 dato.works.forEach.work
6:34:02 PM:     /opt/build/repo/scripts/dato.config.js:113:24
6:34:02 PM:   
6:34:02 PM:   - Array.forEach
6:34:02 PM:   
6:34:02 PM:   - dato.config.js:103 root.directory.workDir
6:34:02 PM:     /opt/build/repo/scripts/dato.config.js:103:16
6:34:02 PM:   
6:34:02 PM:   - dump.js:75 collectOperations
6:34:02 PM:     [repo]/[datocms-client]/lib/dump/dump.js:75:3

See the build log from netlify here and the PR here.

Since this shouldn't be a breaking change I'm assuming this is a bug?

stefanoverna commented 6 years ago

released 0.5.1 with fix, thanks for the report!

ismay commented 6 years ago

That solved it, thanks! 👍