search

datocms / ruby-datocms-client

Ruby client for the DatoCMS API.
https://www.datocms.com/docs/content-management-api/using-the-ruby-client
MIT License
20 stars 14 forks source link

Remove Downloadr gem and force downcase extension #15

Closed roccogalluzzo closed 5 years ago

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.2%) to 94.626% when pulling 4cce5f543b70446a037386d6e85a415a0089fb5f on byterussian:remove-downloadr into 2d70253400b1b2e965dd2b9b4f88dcf8efbec009 on datocms:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.004%) to 94.794% when pulling c0931391aaa19fd64d5f2bc5cadbf416685737ec on byterussian:remove-downloadr into 2d70253400b1b2e965dd2b9b4f88dcf8efbec009 on datocms:master.

stefanoverna commented 5 years ago

@byterussian does it work both for HTTP and HTTPS URLs? And does it follow redirects (301, 302)?

stefanoverna commented 5 years ago

Might be easier to handle these cases using not open-uri but faraday, which we already have as a dependency!

roccogalluzzo commented 5 years ago

OpenURI follow redirects only with ruby versions >= 2.4. Switched to Faraday.