Support pulling images from private container registries - Githubissues

datopian / ckan-cloud-operator

CKAN Cloud operator manages, provisions and configures Ckan Cloud instances and related infrastructure.

MIT License

19 stars 14 forks source link

Support pulling images from private container registries #120

Closed zelima closed 3 years ago

zelima commented 4 years ago

Currently, we only support deis instances to be pulled from private registries https://github.com/datopian/ckan-cloud-operator/blob/master/ckan_cloud_operator/providers/ckan/manager.py#L29

We need it to be enabled for any instance.

Acceptance Criteria

[x] Able to create instance that has image on private container registry (Eg gitlab)

Task

[x] refactor ckan/manager.py to do that other than deis instance https://github.com/datopian/ckan-cloud-operator/blob/master/ckan_cloud_operator/providers/ckan/manager.py#L29
[x] Accept registry credentials from interactive mode (also from interactive.yaml)
[x] Test it is working

zelima commented 3 years ago

FIXED in https://github.com/datopian/ckan-cloud-operator/commit/a65253841b9879e7ac91cea4234264de238adb8a