datopian / ckanext-blob-storage

CKAN extension to offload blob storage to cloud storage providers (S3, GCS, Azure etc).
http://tech.datopian.com/blob-storage/
MIT License
14 stars 4 forks source link

JS/CSS resource loading compatibility for both 2.8 and 2.9 ckan version. #62

Open sagargg-zz opened 3 years ago

sagargg-zz commented 3 years ago

CKAN v2.9 doesn’t support resource js/css imports. This PR includes both resource and assets importer so that it will compatible with both v2.9 and v2.8.

tomeksabala commented 3 years ago

Thanks for this change @sagargg-zz . It was a great help in my project which uses blobstorage and CKAN 2.9 (which depricated fanstatic support with 2.9.3 release).

It'd be great to have it merged to the original repo.

tomeksabala commented 3 years ago

You might also want to have a look at some changes I needed to do in order to make it work with CKAN 2.9.3 I have also updated webassets configuration so it matches default suggested by CKAN ("assets" resources directory name, hypens instead of underscore in names for consistency, etc.) https://github.com/fjelltopp/ckanext-blob-storage/commit/cb22c11107c562c6a74050736337721a38b07fce