This fixes the missing report resources. There was a limit on the output of the API, so I needed to implement a small change for that (data_dict['rows'] = 1000). It seems that the max for rows output is 1000, so I went with that. As they add more datasets and resources, we might hit a wall. I'm not sure if there's a way around this.
Testing with all of their actual datasets, the report is obviously slower to download the larger it is, but as it stands, the wait is about 1-2s to download for the full report.
I also implemented the is_external check that I missed.
Note: I created a new branch for this, but there were some conflicts for some reason. They're fixed now. Also, I'm requesting review on this in case I missed something...
This fixes the missing report resources. There was a limit on the output of the API, so I needed to implement a small change for that (
data_dict['rows'] = 1000). It seems that the max for rows output is 1000, so I went with that. As they add more datasets and resources, we might hit a wall. I'm not sure if there's a way around this.Testing with all of their actual datasets, the report is obviously slower to download the larger it is, but as it stands, the wait is about 1-2s to download for the full report.
I also implemented the
is_externalcheck that I missed.Note: I created a new branch for this, but there were some conflicts for some reason. They're fixed now. Also, I'm requesting review on this in case I missed something...