datopian / ckanext-versioning

Deprecated. See https://github.com/datopian/ckanext-versions. ⏰ CKAN extension providing data versioning (metadata and files) based on git and github.
https://tech.datopian.com/versioning/
GNU Affero General Public License v3.0
7 stars 4 forks source link

Additional Info snippet is showing wrong data #21

Closed pdelboca closed 4 years ago

pdelboca commented 4 years ago

Two distinct issues

Background

When accesing the show page for datasets, the addition info section is showing extra metadata. This may be related on how are we handling package extras field.

image

Tips to Reproduce

Also, when promoting a dataset a tracking_summary is append to the Additional Field info: image

pdelboca commented 4 years ago

This error is related to the Frictionless <-> CKAN mapper.

More info related tags: When doing a round tripping, if I add a tag to the package in CKAN the result of package_show is the following one:

 'tags': [{'display_name': u'FancyTag',
           'id': u'b273a236-e4f8-498b-a64c-fc8f10384afd',
           'name': u'FancyTag',
           'state': u'active',
           'vocabulary_id': None},
          {'display_name': u'NewFancyTag',
           'id': u'8d9e96e0-cf58-44e1-90eb-1b34f778f442',
           'name': u'NewFancyTag',
           'state': u'active',
           'vocabulary_id': None}],

However, the library is only mapping the name of the tag:

 'keywords': [u'FancyTag', u'NewFancyTag'],

So if I do a reconversion using ftc.package() it will return:

'tags': [{'name': u'FancyTag'}, {'name': u'NewFancyTag'}],

Which is missing id, display_name, state and vocabulary_id.



I have also added a comment it the original ticket: https://github.com/frictionlessdata/frictionless-ckan-mapper/issues/33
rufuspollock commented 4 years ago

@pdelboca the question here is 2 fold as i understand it:

rufuspollock commented 4 years ago

FIXED. Contributors and licenses done and tags is in discussion in #32