datopian / ckanext-versioning

Deprecated. See https://github.com/datopian/ckanext-versions. ⏰ CKAN extension providing data versioning (metadata and files) based on git and github.
https://tech.datopian.com/versioning/
GNU Affero General Public License v3.0
7 stars 4 forks source link

Promote -> Revert refactor + allow reverting to revision #48

Closed shevron closed 4 years ago

shevron commented 4 years ago

This PR changes the semantics of the promote action to revert.

In addition, it allows reverting to a revision ID in addition to a named tag, and as a bonus makes the UI just a little bit nicer by adding some padding and icons to buttons.

@pdelboca I would appreciate it if you can review the test that was re-enabled test_revert_updates_extras - because I'm not sure what the expected behavior is when converting extras, I just changed it to what made sense to me (which also currently works).

pdelboca commented 4 years ago

Good job @shevron !