search

datopian / ckanext-versioning

Deprecated. See https://github.com/datopian/ckanext-versions. ⏰ CKAN extension providing data versioning (metadata and files) based on git and github.
https://tech.datopian.com/versioning/
GNU Affero General Public License v3.0
7 stars 4 forks source link

Creating two tags for the same revision will cause confusion #49

Closed uwaheed88 closed 4 years ago

uwaheed88 commented 4 years ago

Issue: IVT-2794

shevron commented 4 years ago

@uwaheed88 we should have probably discussed this better before you implemented a fix, because I don't think the approach you took is correct. Our goal is not to create different revisions (with the same content) so each tag has it's own revision ID. That goes against the model of revisioning / tagging that we want to take.

Our fix should be on the GUI level - the GUI should be aware that we are looking at a tag and what the tag is, and not just have the revision ID in the URL / state. This will resolve this issue in a much cleaner way. Basically, a good fix for this will probably not need to touch anything in the logic / actions level, only modify templates and helpers (most likely).

In addition, please note that CI is failing for this PR. In the future a PR should not be marked as ready for review if CI fails.

shevron commented 4 years ago

I'm closing this for now, if you want to discuss the solution I'm suggesting please ping me, otherwise you can just open a new PR with a better fix.