datopian / ckanext-versioning

Deprecated. See https://github.com/datopian/ckanext-versions. ⏰ CKAN extension providing data versioning (metadata and files) based on git and github.
https://tech.datopian.com/versioning/
GNU Affero General Public License v3.0
7 stars 4 forks source link

Show package revision page requires revision to be tagged #55

Open shevron opened 4 years ago

shevron commented 4 years ago

While the functionality of showing a package in a revision that is not tagged isn't exposed in the GUI yet, the backend for it is in place and we want to have that enabled at some point (esp as #24 is implemented). However, it seems that the code in https://github.com/datopian/ckanext-versioning/blob/master/ckanext/versioning/plugin.py#L95 assumes that any revision we load is already tagged.

The expected value of c.current_version is expected to always be a tag info dict, not a revision.

Probably, what we need is to split the view between a tag and a revision, as they are slightly different things.