datopian / data-api

Next generation Data API for data management systems including CKAN.
https://tech.datopian.com/data-api/
MIT License
9 stars 3 forks source link

Feature/datastore search v1.1 #13

Closed leomrocha closed 3 years ago

leomrocha commented 3 years ago

Basic New API implementation with:

Documentation, Analysis and Examples are also as Markdown files with example screenshots added to the documentation / subdirectory

EvgeniiaVak commented 3 years ago

@leomrocha right now the prettier check is failing: https://hub.docker.com/repository/registry-1.docker.io/datopian/data-api/builds/c05c1271-ec2f-4dc5-8e58-75cbcecd648f

$ /usr/src/app/node_modules/.bin/prettier --check .
Checking formatting...
[warn] ANALYSIS.md

[warn] README.md

[warn] Code style issues found in the above file(s). Forgot to run Prettier?

error Command failed with exit code 1.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Please make sure you use prettier. prittier --write should run by default when you save files (because of vscode settings, probably you'll need a plugin for vscode for this. webstorm has it pre-built, but need to switch on).

EvgeniiaVak commented 3 years ago

Related explanation of builds in dockerhub ci and pull request checks: https://github.com/datopian/data-api/pull/14 @leomrocha please review