datopian / datahub-qa

:package: Bugs, issues and suggestions for datahub.io
https://datahub.io/
32 stars 6 forks source link

[validate] fails on csv with non-comma delimiters #100

Closed anuveyatsu closed 6 years ago

anuveyatsu commented 6 years ago

Validate command fails if I run it on valid dataset that contains different delimiters - https://github.com/frictionlessdata/test-data/tree/master/packages/different-separators

How to reproduce

Expected behavior

anuveyatsu commented 6 years ago

This is now fixed in https://github.com/datahq/datahub-client/pull/16 and https://github.com/datahq/data-cli/commit/2396f4fa13f1e89587e7168fcc4c3e2b7abcb60b

Exact part for this fix: https://github.com/datahq/datahub-client/blob/master/lib/validate.js#L26-L32

The fix will be available with the next release of the CLI tool.

AcckiyGerman commented 6 years ago

FIXED (see previous msg)

TESTED:

user@pc:~/work/datahq/data-cli$ node bin/data.js validate /home/user/work/frictionlessdata/test-data/packages/different-separators/
Your Data Package is valid!