Get command doesn't work for private datasets

datopian / datahub-qa

:package: Bugs, issues and suggestions for datahub.io

https://datahub.io/

32 stars 6 forks source link

Get command doesn't work for private datasets #128

Closed anuveyatsu closed 6 years ago

anuveyatsu commented 6 years ago

If I try to get a private dataset, I'd receive following error message that is unclear to me:

> Error! invalid json response body at https://api.datahub.io/source/...
reason: Unexpected token < in JSON at position 0

How to reproduce

run data get https://datahub.io/anuveyatsu/finance-vix

Expected behavior

I can get my own private dataset
prints more clear message, e.g., "This dataset not found."
I want to see same message for all non-existing datasets

anuveyatsu commented 6 years ago

@AcckiyGerman should be now fixed (https://github.com/datahq/data-cli/issues/301) - will be available in the next release of the CLI tool.

AcckiyGerman commented 6 years ago

@anuveyatsu do we have test for this in QA spreadsheet or data-cli travis tests? coz this issue is major, I think

AcckiyGerman commented 6 years ago

TESTED:

$ node bin/data.js push README.md --private
? Please, confirm name for this dataset:
readme-lazy-penguin-10 get-private-test
? Please, confirm title for this dataset:
Get private test Get private test
🙌  your data is published!
🔗  https://datahub.io/test/get-private-test/v/1 (copied to clipboard)

After some time:

$ node bin/data.js get https://datahub.io/test/get-private-test
Time elapsed: 2.45 s
Dataset/file is saved in "test/get-private-test"