datopian / datahub-qa

:package: Bugs, issues and suggestions for datahub.io
https://datahub.io/
32 stars 6 forks source link

Some data types are not rendered as expected on showcase page #131

Closed anuveyatsu closed 6 years ago

anuveyatsu commented 6 years ago

When rendering data types below, the values are getting converted:

How to reproduce

Expected behavior

AcckiyGerman commented 6 years ago

TESTED: Everything is fixed except Number type. 1.0 is rendered as 1 Tested on datahub.io and on testing.datahub.io @anuveyatsu

anuveyatsu commented 6 years ago

@AcckiyGerman I left it for a reason. We still want to have some values converted to JS objects, e.g., we want Number type to not be String so we can use the values in graphs. But 1.1 would still be 1.1. Another example is Date, sometimes you can have some unusual format but it gets rendered in ISO format. Why? Because otherwise, we wouldn't be able to use those date values in the graphs again.

I guess I should edit the issue desctiption so you can close the issue.

AcckiyGerman commented 6 years ago

Thanks for update. I just checked that Numbers values is the same in result data. If it is render 1 instead 1.0 only on the frontend - that's OK

FIXED: Different data types are rendered properly in the preview table. Only exception is 1.0 -> 1 for using this values in the graphs.