`data validate` accepts wrong headers, if no data rows

datopian / datahub-qa

:package: Bugs, issues and suggestions for datahub.io

https://datahub.io/

32 stars 6 forks source link

`data validate` accepts wrong headers, if no data rows #202

Closed AcckiyGerman closed 8 months ago

AcckiyGerman commented 6 years ago

data validate reports false your package is valid when

data file contains no data inside
data file have only 1 row with invalid headers.

How to reproduce

Try to validate this dataset: invalid_dataset.zip

Expected behavior

Create a valid datapackage with tabular resource (data init) and then break the data. data validate should reports errors for situations:

[ ] data file is empty
[ ] data file have only 1 row with invalid headers.

AcckiyGerman commented 6 years ago

Added two test cases in our QA tests spreadsheet

anuveyatsu commented 6 years ago

@AcckiyGerman I have left a comment in the similar issue in tableschema-js repo - https://github.com/frictionlessdata/tableschema-js/issues/131#issuecomment-381087226 I guess it should be fixed from there.

anuveyatsu commented 6 years ago

@AcckiyGerman by the way, do you think this issue should be considered as "Major"?

AcckiyGerman commented 6 years ago

Not really, I just wanted to get attention to the bug, it is Minor, I think

On Apr 24, 2018 21:58, "Anuar Ustayev" notifications@github.com wrote:

@AcckiyGerman https://github.com/AcckiyGerman by the way, do you think this issue should be considered as "Major"?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/datahq/datahub-qa/issues/202#issuecomment-384060196, or mute the thread https://github.com/notifications/unsubscribe-auth/ALKlIksSXIEoe28gJY40tMI2930HtdHOks5tr4P-gaJpZM4TS-IH .