datopian / datahub-qa

:package: Bugs, issues and suggestions for datahub.io
https://datahub.io/
32 stars 6 forks source link

Make sure content types are correct for derived resources #231

Closed zelima closed 6 years ago

zelima commented 6 years ago

If you try and click on JSON resource on datahub it's open in new tab, while it should be directly downloaded. Meaning maybe content type for it is set to text plain.

How to reproduce

Expected behavior

should start download driectly

zelima commented 6 years ago

FIXED this was never an issue

curl -s -I -L https://datahub.io/core/finance-vix/r/vix-daily.json
HTTP/1.1 302 Found
Date: Wed, 13 Jun 2018 04:52:08 GMT
Content-Type: text/plain; charset=utf-8
Content-Length: 139
Connection: keep-alive
Set-Cookie: __cfduid=d7f3a7cbe00ebb80a45cbf6f3f579a7e81528865527; expires=Thu, 13-Jun-19 04:52:07 GMT; path=/; domain=.datahub.io; HttpOnly
X-Powered-By: Express
Access-Control-Allow-Origin: *
Location: https://pkgstore.datahub.io/core/finance-vix/vix-daily_json/data/5a077e1e162c4ff08151a90bcf99e5d4/vix-daily_json.json
Vary: Accept
set-cookie: connect.sid=s%3AmY1hZK0SeqhDUgTOJbKfEP9H0URmspHi.G37u9I7ec9k8VkPSequES5aZOJKaZ2FsdNRK0L5jlmI; Path=/; Expires=Wed, 13 Jun 2018 04:53:08 GMT; HttpOnly
Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
Server: cloudflare
CF-RAY: 42a1f228185d97f2-FRA

HTTP/1.1 200 OK
Date: Wed, 13 Jun 2018 04:52:08 GMT
Content-Type: application/json
Content-Length: 343652
Connection: keep-alive
Set-Cookie: __cfduid=dc23cc5f90862b2426e29bc4081ebb80d1528865528; expires=Thu, 13-Jun-19 04:52:08 GMT; path=/; domain=.datahub.io; HttpOnly
x-amz-id-2: m6BEmN4SG60lOgfsO+yRLSlPuTolftHn2+RFDF4WZc7BaJstgOmYUFwYdqm7YcuXFBv/QJS5LmI=
x-amz-request-id: D3989B90268F034A
Last-Modified: Tue, 12 Jun 2018 20:31:08 GMT
ETag: "5a077e1e162c4ff08151a90bcf99e5d4"
Accept-Ranges: bytes
Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
Server: cloudflare
CF-RAY: 42a1f2325da3634f-FRA