[Push] pushing the files with modified extensions

[zelima]

As a user, I might have files that are CSV or EXCEL or any other but have modified extensions. Eg my-file.xls renamed and called my-file.csv. Right now they are failing with not a user-friendly error messages

How to reproduce

• take a TSV file, change its extension to .csv and push
• take a XLS file, change its extension to .csv and push
• take a pdf file, change its extension to .csv and push
• take a XLS file, change its extension to .xlsx and push
• take a CSV file, change its extension to .xlsx and push
• take a PDF file, change its extension to .xlsx and push

Expected behavior

tell the user that content is not correct Format

[Mikanebu]

@zelima I tried the following cases:

• tsv=> csv - CLI - OK, showcase - OK - https://datahub.io/Mikanebu/extenstion-test-1
• csv => tsv - CLI - OK, showcase - Broken -CastError: Row length 1 doesn't match fields count 4
• xlsx => csv CLI - broken > Error! Invalid opening quote at line 2
• csv => xlsx CLI - OK, showcase -OK - only zip resource - probably, this is bug
• pdf => csv - CLI - broken > Error! Invalid opening quote at line 24
• csv => pdf - CLI - OK, showcase - OK - only zip resource - probably, this is bug
• xlsx => xls - CLI - OK, showcase - OK - only zip resource - probably, this is bug
• xls => xlsx - CLI - OK, showcase - OK - only zip resource - probably, this is bug
• xls => pdf - CLI - OK, showcase - OK - only zip resource - probably, this is bug
• pdf => xls - CLI - OK, showcase - OK - only zip resource - probably, this is bug

We can handle cases when CLI throws error, otherwise I do not see the point why we need to handle this cases. What do you think?

[zelima]

@Mikanebu I agree, indeed I think in the case it's erroring for csv is totally fine. Think we can close this as WONTFIX. Think the fact that we see only zip is cause of we changed spec recently and instead of non-tabular we have original cc @anuveyatsu @akariv

[Mikanebu]

WONTFIX as discussion suggests