[push] show proper error when `resources.path` is invalid

[AcckiyGerman]

As a user I want to see a readable error when I push the data, so I could fix my dataset. But now, when I push a dataset with invalid resources.path I've got

• > Error! [object Promise] if I have ../ in the path OR
• got no error from data-cli, dataset is pushed and then I have Not Found for url: error on the frontend.

How to reproduce

Push datasets with following errors in the datapackage.json (use https://github.com/frictionlessdata/test-data/packages/ ...invalid packages):

• [x] invalid path to local file
• [ ] invalid URL to remote file
• [x] ../ in the resource.path

Expected behavior

• [x] user got an error when tries to data push dp.json with ../ in the resources.path
  • the path of <name> resource is invalid OR
  • using backwards "../" in the path is prohibited due to security reasons
• [x] user got an error when there is NO file on the given path
  • the path of <name> resource is invalid OR
  • file not found on path <path>

Related issues:

• [x] https://github.com/datahq/data-cli/issues/265

[AcckiyGerman]

FIXED: https://github.com/datahq/data-cli/issues/265#issuecomment-366716624 Fix works only on testing server ATM

[AcckiyGerman]

@zelima could you update the production specstore with your "return errors" fix https://github.com/datahq/specstore/commit/fde06cdbbc223b7f33dcae7d4787af439383ea33 and I will close the issue.

[zelima]

@AcckiyGerman updated

[AcckiyGerman]

TESTED & FIXED

invalid-backward-path$ data push
> Error! Unexpected error: Local path "../../files/csv/separators/comma.csv" is not safe