search

datopian / datahub-qa

:package: Bugs, issues and suggestions for datahub.io
https://datahub.io/
32 stars 6 forks source link

Notify users about new versions of the data CLI tool #97

Closed anuveyatsu closed 6 years ago

anuveyatsu commented 6 years ago

User story: as a Publisher I want to get notified about cli tool updates so I always use bug-free and improved software.

I cannot know if a newer version of the data-cli tool was released unless I visit the website or go to releases page (or read gitter channels for updates).

How to reproduce

Expected behavior

anuveyatsu commented 6 years ago

This will be fixed in https://github.com/datahq/data-cli/issues/198

anuveyatsu commented 6 years ago

This PR https://github.com/datahq/data-cli/pull/271 will fix this issue and it will be available with the next release of the CLI tool.

anuveyatsu commented 6 years ago

FIXED and working since v0.7.4 of the data-cli

AcckiyGerman commented 6 years ago

Issue will be closed, when I will see the notification of v0.7.5 :)

anuveyatsu commented 6 years ago

@AcckiyGerman you should see notification of v.0.7.6 if you're using the older version. Make sure you're not using the cli tool with npm link because in this case you likely using the v0.7.6 already

anuveyatsu commented 6 years ago

@AcckiyGerman oh, I see it is not showing up a notification when running the CLI tool as binary executable.. will investigate

AcckiyGerman commented 6 years ago

hmmm, I just checked twice and it works with my v.0.7.4 binary. I could see the notification and the instruction how to update...

@anuveyatsu The only thing is - when copying instructions from the terminal - I have | pipes in my clipboard:

wget https://github.com/datahq/data-cli/releases/download/v0.7.6/data-linux.gz              │
   │   gunzip -f data-linux.gz && chmod +x data-linux && sudo mv data-linux /usr/local/bin/data    │
   │   data -v # should print 0.7.6

And commands not work then :( Let's remove the | pipes decoration | from around the code, so user could just copy-paste

anuveyatsu commented 6 years ago

@AcckiyGerman that's strange, there shouldn't be any pipes. By the way, I probably not getting a notification as it caches the result of update check - it checks only every 1h. I will check if I have any pipes in a bit.

AcckiyGerman commented 6 years ago

TESTED & FIXED @anuveyatsu one suggestion - please, remove | pipes that decorates instruction - otherwise user cannot use multiline copy-paste (decorators get into the clipboard)