datopian / datapackage-views-js

View library for datapackages and datapackage resources
12 stars 9 forks source link

Add JSON and XML views rendering #46

Open EvgeniiaVak opened 4 years ago

EvgeniiaVak commented 4 years ago

Job story

When having JSON / XML data resource, I want to be able to use datapackage-views-js to render data view, so that I can see it before / instead of downloading.

Acceptance criteria

Tasks

Analysis

Text spec

datapackage-views-js already has 'document' spec for rendering PDF views, JSON / XML could also have a similar dedicated spec type - text that would:

Rendering libraries

rufuspollock commented 4 years ago

@EvgeniiaVak surely we just do this in pure frontend app - doing this datapackage-views-js seems a bit crazy. datapacakge-views-js is focused on proper rendering and visualizing.

gavram commented 4 years ago

@rufuspollock @EvgeniiaVak

When I spoke with Anu about this we were talking about datapackage-views-js. But I would agree with Rufus that all can be done in frontend app.

The only thing that goes in favor of datapackage-views-js is to keep all the visualizations in one place

EvgeniiaVak commented 4 years ago

I agree with @rufuspollock actually. If we try to fit all visualizations in one place, this place would grow to be too large and we would end up loading to much unnecessary code to places where it is not used cc @gavram @anuveyatsu

EvgeniiaVak commented 4 years ago

notes on this issue from the meeting with @anuveyatsu and @gavram

anuveyatsu commented 4 years ago

@rufuspollock depends on what do you mean by frontend app. Main point for me is to do it on client as JSON/XML files can be large. Doing this in datapackage-views-js sounds correct to me because:

cc @EvgeniiaVak @gavram

Another way would be to do it in frontend templates so it is still client-side.

rufuspollock commented 4 years ago

OK, then this needs a bit of analysis. Whether on client or server loading 100Mb of json is not going to work well ...

On Wed, Aug 5, 2020 at 7:46 AM Anuar Ustayev notifications@github.com wrote:

@rufuspollock https://github.com/rufuspollock depends on what do you mean by frontend app. Main point for me is to do it on client as JSON/XML files can be large. Doing this in datapackage-views-js sounds correct to me because:

  • it is a view
  • we can render based on view type

cc @EvgeniiaVak https://github.com/EvgeniiaVak @gavram https://github.com/gavram

Another way would be to do it in frontend templates so it is still client-side.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/datopian/datapackage-views-js/issues/46#issuecomment-668993081, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABMDMUPF55NNTSO6ZIRQXLR7DWZ3ANCNFSM4PLMY3PA .