search

datopian / datapipes

Data Pipes for CSV
https://datapipes.okfnlabs.org/
MIT License
117 stars 16 forks source link

Update dependencies #125

Closed serahkiburu closed 6 years ago

andylolz commented 6 years ago

Thanks for this, @serahrono!

Do you mind if I take a look at this tomorrow / over the weekend? I’d also like to get the test suite working again.

serahkiburu commented 6 years ago

no problem, @andylolz 👍

andylolz commented 6 years ago

Cool! (This PR can serve as motivation to get this project up and running again! 🏆 )

rufuspollock commented 6 years ago

@andylolz can you merge?

andylolz commented 6 years ago

@serahrono @rufuspollock It looks like there are some issues related to upgrading from express 3 to 4: https://github.com/expressjs/express/wiki/Migrating-from-3.x-to-4.x

I’m just working on getting tests fixed on master. Then I’ll merge that into this branch, and this can be the upgrade branch. Does that sound okay?

andylolz commented 6 years ago

Okay, cool! master is fixed now :tada: So errors on this branch are now related to the dependency update – I think it’s just stuff from the express migration. These definitely need to be resolved before this branch can be merged.

I don’t want to block anyone else from taking a look at this – @serahrono if you want to look into doing the express migration, please do! If not, I’ll take a look later this week.

andylolz commented 6 years ago

I’ve pinned the csv package to the latest version that it’s easy to get working. Ideally we’d use a more recent version, but it’ll take a bit of thinking.

So this PR upgrades express.js, and does fix #117. As such, I’m happy to merge it! Thanks both!

andylolz commented 6 years ago

Deployed – looks good to me.

rufuspollock commented 6 years ago

@andylolz 👍 awesome