datopian / datapipes

Data Pipes for CSV
https://datapipes.okfnlabs.org/
MIT License
117 stars 16 forks source link

HTTPS support #127

Closed fgregg closed 6 years ago

fgregg commented 6 years ago

Thanks for a great resource!

I recently updated my website to support https. Unfortunately, the embedded datapipes no longer show up because it is http only

http://datapipes.okfnlabs.org/csv/html/?url=https://bunkum.us/svo/data/fuel_properties.csv

works, but cannot be embedded in my https site

https://datapipes.okfnlabs.org/csv/html/?url=https://bunkum.us/svo/data/fuel_properties.csv

causes an insecure connection error in my browser (Firefox 59)

Would you be able to provide https support?

andylolz commented 6 years ago

Very good point – thanks for raising this, @fgregg!

looks like https://okfnlabs.org supports https, so I guess we’d need a wildcard certificate for the domain. I’ve opened a ticket for that: okfn/okfn.github.com#521

I’ve had a go at enabling this.

$ heroku certs:auto
=== Automatic Certificate Management is enabled on datapipes

Domain                  Status
──────────────────────  ───────────
datapipes.okfnlabs.org  In Progress

The heroku docs say this could take up to 3 days. So fingers crossed, and let’s revisit!

andylolz commented 6 years ago

Hmm – it’s failing…

$ heroku certs:auto
=== Automatic Certificate Management is enabled on datapipes

Domain                  Status
──────────────────────  ───────
datapipes.okfnlabs.org  Failing

=== Some domains are failing validation, please verify that your DNS matches: heroku domains

$ heroku domains
=== datapipes Heroku Domain
datapipes.herokuapp.com

=== datapipes Custom Domains
Domain Name             DNS Record Type  DNS Target
──────────────────────  ───────────────  ────────────────────────────────────
datapipes.okfnlabs.org  CNAME            datapipes.okfnlabs.org.herokudns.com

@rufuspollock are you able to check the DNS record on okfnlabs.org matches the one above? I’ll ask on okfn/chat gitter too, in case it’s someone else with this power! (Tagging @vitorbaptista, too).

andylolz commented 6 years ago

Hmm… While it still says failing:

$ heroku certs:auto
=== Automatic Certificate Management is enabled on datapipes

Domain                  Status
──────────────────────  ───────
datapipes.okfnlabs.org  Failing

…https does now seem to be working: https://datapipes.okfnlabs.org

Does this appear fixed to you, @fgregg?

fgregg commented 6 years ago

it does! Thank you!

andylolz commented 6 years ago

Possibly @rufuspollock or @vitorbaptista fixed it?!

In any case, closing this, as it looks to be fixed.

Thanks for reporting, @fgregg!