search

datopian / factory

Datahub factory for dataflows
5 stars 1 forks source link

Incomplete docs re adding new datasets #9

Open anuveyatsu opened 5 years ago

anuveyatsu commented 5 years ago

E.g., we've tried to add https://github.com/datasets/co2-ppm-daily into factory to run it on daily basis but it turned out you need to make more than it is said in the README. We were receiving following error:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/datapackage_pipelines/specs/../lib/flow.py", line 13, in <module>
    flow = flow_module.flow(parameters, datapackage, resources, ctx.stats)
AttributeError: module 'co2-ppm-daily-flow' has no attribute 'flow'

It was fixed after adding flow method in the flow script, see https://github.com/datasets/co2-ppm-daily/blob/master/co2-ppm-daily-flow.py#L76

zelima commented 5 years ago

@anuveyatsu that is documented here https://github.com/frictionlessdata/datapackage-pipelines/#dataflows-integration (but probably worth to have here as well)