search

datopian / flexidate

Date parsing and normalization utilities for Python.
MIT License
21 stars 15 forks source link

Porting FlexiDate for Python 3 #1

Closed kylepjohnson closed 8 years ago

kylepjohnson commented 8 years ago

Hi, I lead the CLTK, a collection of software tools for natural language processing. There has been interest by some in the project in porting your FlexiDate to Python 3, as we need it to track the dates of ancient authors.

I'm writing because it is likely that someone will fork this project and make it Python 3 compliant. Do you have any preferences for how this is done? As the project hasn't been updated in 4 years, I wonder whether you have interest in still maintaining it.

Thanks much!

rufuspollock commented 8 years ago

@kylepjohnson first i think the CLTK project is great :-)

Rather than fork obviously the preference would be to update this here - pull requests are very welcome and will get merged. The project has not been updated because it was largely working and there have been no requests :-)

We're also happy to make you a maintainer going forward if you were looking to contribute on an ongoing basis.

kylepjohnson commented 8 years ago

@rgrp Thanks for the prompt response! OKFN and CLTK share a lot in common :)

I agree that it is preferable not to fork. It is a testament to the code that it's lasted so long.

As for maintaining, I or one of our students might be interested. I'll post back on our issue tracker sharing that this is an option and I'll be in touch back here.

rufuspollock commented 8 years ago

@kylepjohnson fantastic!

Akirato commented 8 years ago

@rgrp I made some changes to the flexidate code and it runs all the tests for both Python2 and Python3 and works properly for the commands I checked. Here's the repo: https://github.com/Akirato/flexidate_python3 Please tell me if it works fine or if it has any problems.

kylepjohnson commented 8 years ago

@rgrp There was duplicated efforts here, so apologies about the noise.

The first PR is probably the more thorough of the two, as the build server confirms it's Py2 and 3 compatible.

rufuspollock commented 8 years ago

@kylepjohnson should i ignore the other PR? If so I can merge immediately since the one you link looks good whilst the other had a few issues.

kylepjohnson commented 8 years ago

Hi Rufus, yes please do ignore the other PR. The student who made it is motivated to help, so he may yet be in touch with you about miscellaneous improvements, if there are any.

Also, would you mind pinging me when the new version is up on PyPI?

Thank you! Kyle

On Saturday, March 19, 2016, Rufus Pollock notifications@github.com wrote:

@kylepjohnson https://github.com/kylepjohnson should i ignore the other PR? If so I can merge immediately since the one you link looks good whilst the other had a few issues.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/okfn/flexidate/issues/1#issuecomment-198777515

rufuspollock commented 8 years ago

@kylepjohnson sure and could even make you an admin on pypi.

rufuspollock commented 8 years ago

PS: does your committer want to bump version number and add something to README about supporting both py 2 and 3 :-)

kylepjohnson commented 8 years ago

Yes, I'll let him know to update the version and README. He'll want to do this himself, so thank you for thinking of it.

Once these fixes are in, go ahead and push. If it turns out that we have need to adjust FlexiDate slightly again, I'll consider your offer of being added on PyPI. I appreciate it, just that I'm juggling a lot with GSoC right now!

On Wednesday, March 23, 2016, Rufus Pollock notifications@github.com wrote:

PS: does your committer want to bump version number and add something to README about supporting both py 2 and 3 :-)

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/okfn/flexidate/issues/1#issuecomment-200369123

Kyle P. Johnson, Ph.D.

Natural language processing, data science, architecture https://kyle-p-johnson.comkyle@kyle-p-johnson.com | https://kyle-p-johnson.com | https://github.com/kylepjohnson

Classical Language Toolkit, Founder http://cltk.org | https://github.com/cltk/cltk

kylepjohnson commented 8 years ago

@rgrp Do you want to call call this version 1.1 or 2.0?

nishnik commented 8 years ago

@rgrp Could you please add :

They will help us a lot in further developments.

kylepjohnson commented 8 years ago

Thank you, Nishant.

In my opinion, we only need Codecov or Coveralls, as they do basically the same thing. Of the two, I recommend Codecov, as it has a much better interface.

On Wednesday, March 23, 2016, Nishant Nikhil notifications@github.com wrote:

@rgrp https://github.com/rgrp Could you please add :

They will help us a lot in further developments.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/okfn/flexidate/issues/1#issuecomment-200500049

Kyle P. Johnson, Ph.D.

Natural language processing, data science, architecture https://kyle-p-johnson.comkyle@kyle-p-johnson.com | https://kyle-p-johnson.com | https://github.com/kylepjohnson

Classical Language Toolkit, Founder http://cltk.org | https://github.com/cltk/cltk

rufuspollock commented 8 years ago

@kylepjohnson i suggest we call this v1.1. v2 can be reserved for a major feature upgrade.

@nishnik and @kylepjohnson I will make you admins on this repo so you can add stuff.

kylepjohnson commented 8 years ago

Thanks @rgrp, we appreciate it!

@nishnik I'll let you do the updates.

nishnik commented 8 years ago

@kylepjohnson @rgrp I am not able to add Travis CI and Codecov access. Because, only a person with admin right can do that. Screen-shot from Travis CI's site: selection_024

kylepjohnson commented 8 years ago

@rgrp I reviewed and the latest PR #5 is ready to merge.

rufuspollock commented 8 years ago

@nishnik @kylepjohnson sorry i had not got permissions right but fixed again and you should have admin now :smile:

kylepjohnson commented 8 years ago

Fantastic. Thanks for bringing us on board!

Travis builds started: https://travis-ci.org/okfn/flexidate/builds/119833778.

We just need to setup Codecov are this ticket can be closed.

nishnik commented 8 years ago

@kylepjohnson Codecov has been setup. We can close this now!

kylepjohnson commented 8 years ago

Ping @rgrp the library is ready for upload to PyPI.

witekdev commented 5 years ago

Hi @kylepjohnson and @rufuspollock

Would it be possible to ask for a release at this late stage (2 years+ later)? From what I can see, this release never happened. I see that pypi lists only the original 1.0. release https://pypi.org/project/flexidate/

I see there is an outstanding issue here asking for a release https://github.com/openknowledge-archive/flexidate/issues/8

Or was this perhaps released elsewhere under a different package? Thank you.

rufuspollock commented 5 years ago

@kylepjohnson if have given you permissions so you release to pypi (i had a hiatus where i did not have access to pypi). Can you do that?

kylepjohnson commented 5 years ago

@rufuspollock For the time being, I don't mind helping as PyPI maintainer. I would appreciate write access to this repo, too (if I don't already have it), so that I can troubleshoot any config issues that should arise.

In the long run, there is probably someone else, in the ancient world DH community, who might be a better candidate. But let's see where it goes.

I'll open a ticket on the CLTK's repo so this doesn't get lost.