search

datopian / flowershow

💐 Publish your obsidian digital garden or any markdown site easily and elegantly.
https://flowershow.app/
MIT License
824 stars 98 forks source link

Search component breaks on Next v13.1.6 #419

Closed khalilcodes closed 1 year ago

khalilcodes commented 1 year ago

After doing a local test upgrade for next to latest version (13.1.6) the site throws the following error in Nav.

Screen Shot 2023-02-06 at 4 30 10 PM

Upon further investigation it was found that the Search component is the underlying issue.

Browsing through pliny's code (which is where this was ported from), he has disabled this feature entirely maybe due to similar errors (and looks like he is not going to maintain that feat anytime soon).

Acceptance

Tasks

olayway commented 1 year ago

@khalilcodes I'm not sure if it's a matter of Next.js version, because I saw it also while working on next.datopian.com. I knew that the site builds correctly on Cloudflare but I was getting this error when running a dev server locally, so I had to comment out the SearchProvider in the Layout to be able to work on other things 😅 Next time it shows up I'll let you know what versions of Node and Next.js I'm using.

rufuspollock commented 1 year ago

@olayway i've also had this locally.

olayway commented 1 year ago

@rufuspollock Thanks for reporting. I'm adding this issue to our next sprint as this shouldn't happen and is pretty annoying.

olayway commented 1 year ago

@rufuspollock can you also let us know which node version and OS you're using? And when exactly did this error show up? Were you able to run the project previously without the error?

khalilcodes commented 1 year ago

@olayway updates:

updated all deps with some changes in component, and works on node 16 & 18.

blocked by mermaid which throws errors when creating new site.