datopian / flowershow

💐 Publish your obsidian digital garden or any markdown site easily and elegantly.
https://flowershow.app/
MIT License
824 stars 98 forks source link

Link previews per page added #456

Closed PhilippeduPreez closed 1 year ago

PhilippeduPreez commented 1 year ago

closes #455

Link previews boolean added to frontmatter

Changes

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: b04d7563c30938995da5a7f9857c6d4828bb0cad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @flowershow/template | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for spectacular-dragon-c1015c ready!

Name Link
Latest commit b04d7563c30938995da5a7f9857c6d4828bb0cad
Latest deploy log https://app.netlify.com/sites/spectacular-dragon-c1015c/deploys/64072afdbedbb70007ebc961
Deploy Preview https://deploy-preview-456--spectacular-dragon-c1015c.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rufuspollock commented 1 year ago

@PhilippeduPreez why are we implementing this feature? This will add complexity to the app and it seems very specific need - what was the use case for this feature?

olayway commented 1 year ago

@PhilippeduPreez why are we implementing this feature? This will add complexity to the app and it seems very specific need - what was the use case for this feature?

@rufuspollock The use case is our home page, where we originally had links to features' doc pages under "Read more" and I don't think it looked good. Now we only have one wiki link on that page (and I still think it should go), so this could probably wait but tbh I'm glad we could have this option now, as I personally wouldn't like to see tooltip previews on my personal site's home page or on any index pages.

Not sure what is the complexity added here. We have options to enable/disable things per-page for anything else and it's 3 lines of code that has been changed. And it probably took 5 min of work.