datopian / flowershow

💐 Publish your obsidian digital garden or any markdown site easily and elegantly.
https://flowershow.app/
MIT License
757 stars 92 forks source link

Fix page render (client-side) error #466

Closed khalilcodes closed 1 year ago

khalilcodes commented 1 year ago

Fixes #451

Summary

This PR adds a fix to pages not rendering caused by errors related to tooltips for empty pages/files.

Changes

TODO (before merge):

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 78711b9034d74ca334f2676b03b46332cd84fa64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @flowershow/core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for spectacular-dragon-c1015c ready!

Name Link
Latest commit 78711b9034d74ca334f2676b03b46332cd84fa64
Latest deploy log https://app.netlify.com/sites/spectacular-dragon-c1015c/deploys/6425f40da0fc8000085257d9
Deploy Preview https://deploy-preview-466--spectacular-dragon-c1015c.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rufuspollock commented 1 year ago

@khalilcodes is this good for @olayway to review now?

khalilcodes commented 1 year ago

@rufuspollock Yes this is ready for merge. @olayway although this is a quick fix, it can be further refactored and simplified by using only frontmatter descriptions since we now have them computed for all pages by default.

rufuspollock commented 1 year ago

@olayway @khalilcodes can we get this merged now?