datopian / flowershow

💐 Publish your obsidian digital garden or any markdown site easily and elegantly.
https://flowershow.app/
MIT License
750 stars 92 forks source link

Transclusions/Note embeddings cause hydration errors #545

Closed Mr-Pine closed 10 months ago

Mr-Pine commented 11 months ago

Currently, if a markdown file contains an Obsidian-style transclusion like ![[my-other-note.md]] you get an error in dev mode

Error message

image

and nothing happens in export mode.

I understand that that is a pretty big feature, but I have found very litte (up to date) information on whether and when support for transclusions is planned.

In the meantime, it might make sense to transform transclusions into normal links, so that not all functionality is lost and the site is not unusable in dev mode

olayway commented 11 months ago

@Mr-Pine thank you for submitting the issue! I totally agree, Obsidian note embeds shouldn't throw an error and at least temporarily should be converted to links. I'll take care of it!

olayway commented 10 months ago

@Mr-Pine This has just been fixed. Thanks again for reporting this issue! 🌷

Mr-Pine commented 10 months ago

Awesome!