datopian / flowershow

💐 Publish your obsidian digital garden or any markdown site easily and elegantly.
https://flowershow.app/
MIT License
750 stars 92 forks source link

Be able to change the favicon #557

Closed tardigrde closed 9 months ago

tardigrde commented 10 months ago

User story: as a publisher, I want to be able to customize my website UX by being able to change the favicon (https://en.wikipedia.org/wiki/Favicon).

referring to comment: https://github.com/datopian/flowershow/issues/541#issuecomment-1674186332

Thanks in advance!

avinashkanaujiya commented 10 months ago

I did manage to change it, will add it here.

delversclub commented 10 months ago

I did manage to change it, will add it here.

Any update on how you managed to change it?

avinashkanaujiya commented 10 months ago
export default {
    nextSeo: {
        // title: "MyBlog blog post",
        // description: "This is a blog about data management",
        additionalLinkTags: [
            {
              rel: 'icon',
              href: "/images/obsidian-icon.ico",
            },
          ],
      },
     // your other configs
};

this should be added to content/config.mjs file

avinashkanaujiya commented 10 months ago

let me know if it works...

a-oneil commented 10 months ago

let me know if it works...

@avinashkanaujiya I'm not the OP but no luck with the provided code. This is able to pass javascript validation, is there something I'm missing?

const config = {
  title: "Testing",
  description: "A personal blog about InfoSec, Networking, and Electronic Projects.",
  author: "Testing",
  authorLogo: "/images/me.png",
  domain: "https://testing.com",
  // navLinks: [{ href: "https://github.com", name: "Github" }],
  navBarTitle: {
      logo: "/images/logo.png" // optional
  },
  nextSeo: {
      additionalLinkTags: [
          {
              rel: 'icon',
              href: "/images/favicon.ico",
          },
      ]
  },
};

export default config;
tardigrde commented 10 months ago

Does not work for me either :/ No warning in deployment or in the browser console.

If I have public/assets/images/logo.png file it should work with this config?

const config = {
 # other config parmas
  nextSeo: {
      additionalLinkTags: [
          {
            rel: 'icon',
            href: "/assets/images/logo.png",
          },
      ],
  },
};
avinashkanaujiya commented 10 months ago

Did you check, what is visible in the inspector, in meta section. See if link is getting registered properly in the meta tags. Also try removing the cache.

On Sat, Sep 9, 2023, at 16:01, Levente Csőke wrote:

Does not work for me either :/ No warning in deployment or in the browser console.

If I have public/assets/images/logo.png file it should work with this config?

const config = {

other config parmas

nextSeo: { additionalLinkTags: [ { rel: 'icon', href: "/assets/images/logo.png", }, ], }, };

— Reply to this email directly, view it on GitHub https://github.com/datopian/flowershow/issues/557#issuecomment-1712479347, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6QX7K6Z2THQ3U4QOV2S3TXZRAP5ANCNFSM6AAAAAA3X27T6Q. You are receiving this because you were mentioned.Message ID: @.***>

olayway commented 9 months ago

@tardigrde, @avinashkanaujiya, @delversclub, @rc-austinoneil

I can confirm the favicon is not customizable atm. Thank you for flagging your interest in this feature! I'll do my best to include this in the next version.

olayway commented 9 months ago

Closing as duplicate of #277