search

datopian / frontend-v2

CKAN / Data Portal frontend as microservice in pure Javascript (Node).
http://tech.datopian.com/frontend/
MIT License
38 stars 18 forks source link

Generic error handler for async routes #169

Closed anuveyatsu closed 4 years ago

anuveyatsu commented 4 years ago

Hey @EvgeniiaVak please review this PR when you have time 😄

EvgeniiaVak commented 4 years ago

@anuveyatsu Maybe it's not a terribly valid way to test it, but here what I've got:

  1. checked out the fix branch
  2. launched with oddk theme (newest master branch)
  3. checked that with normal settings works ok
  4. changed WP_URL to 'https://test-non-existant-justfor-test-here.home.blog/
  5. launched and got this:
Screen Shot 2020-04-24 at 6 10 08 PM
  1. tried with fronend-v2 master branch - the page doesn't even load

=> I love this! we won't have Unhandled promise rejection. anymore