search

datopian / metastore-lib

🗄️ Library for storing dataset metadata, with versioning support and pluggable backends including GitHub.
https://tech.datopian.com/versioning/
MIT License
10 stars 1 forks source link

Add LFS config / pointer file support for relevant resources #10

Closed shevron closed 4 years ago

shevron commented 4 years ago

This implements #5

shevron commented 4 years ago

Overall looks good, tested it locally and works altough vainilla CKAN adds a full URL to the path of the resource, something like: http://ckan:5000/dataset/e2fc69d3-ff63-4664-9704-2175a9b6a0dc/resource/9e185c27-e5ea-4233-8b97-ef7cdf6291a1/download/mini-csv.csv.

So I will need to install other extension like ckanext-external-storage to test it better.

Yes, and in that case the file is surely not in LFS anyway, so it's fine. IIRC both ckanext-external-storage and ckanext-cloudstorage will set the URL to the original file name, not the full download URL.